Add variables for xml.fileAssociations#334
Merged
angelozerr merged 1 commit intoredhat-developer:masterfrom Oct 30, 2020
Merged
Add variables for xml.fileAssociations#334angelozerr merged 1 commit intoredhat-developer:masterfrom
xml.fileAssociations#334angelozerr merged 1 commit intoredhat-developer:masterfrom
Conversation
Contributor
Author
|
This change is client only: the variables only in vscode-xml, not any of the other clients that LemMinX supports. Still need to:
|
datho7561
force-pushed
the
307-variables-in-file-associations
branch
3 times, most recently
from
5cd3a2f to
7e10726
Compare
datho7561
force-pushed
the
307-variables-in-file-associations
branch
2 times, most recently
from
20eedb1 to
cef9c32
Compare
Collaborator
|
please rebase against master |
datho7561
force-pushed
the
307-variables-in-file-associations
branch
from
cef9c32 to
517a905
Compare
Contributor
Author
|
|
datho7561
force-pushed
the
307-variables-in-file-associations
branch
2 times, most recently
from
517a905 to
9d63ce5
Compare
angelozerr
reviewed
Oct 27, 2020
angelozerr
reviewed
Oct 27, 2020
angelozerr
reviewed
Oct 27, 2020
angelozerr
reviewed
Oct 27, 2020
datho7561
force-pushed
the
307-variables-in-file-associations
branch
from
9d63ce5 to
64a4ec1
Compare
angelozerr
reviewed
Oct 28, 2020
angelozerr
reviewed
Oct 28, 2020
angelozerr
reviewed
Oct 28, 2020
datho7561
force-pushed
the
307-variables-in-file-associations
branch
from
64a4ec1 to
1daefbf
Compare
angelozerr
reviewed
Oct 28, 2020
Adds three variables that can be used in `xml.fileAssociations`:
* ${workspaceFolder}
* ${fileDirname}
* ${fileBasenameNoExtension}
These variables can be used for both the `pattern` and the `systemId`.
Closes redhat-developer#307
Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
307-variables-in-file-associations
branch
from
1daefbf to
d9582c6
Compare
angelozerr
approved these changes
Oct 30, 2020
Contributor
angelozerr
left a comment
angelozerr
left a comment
There was a problem hiding this comment.
Great job @datho7561 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three variables that can be used in
xml.fileAssociations:These variables can be used for both the
patternand thesystemId.Closes #307
Signed-off-by: David Thompson davthomp@redhat.com